Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 652813003: CC: Fix issue for animations with fill and iteration start specified (Closed)

Created:
6 years, 2 months ago by samli
Modified:
6 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CC: Fix issue for animations with fill and iteration start specified Animations with both or backwards fill mode specified along with a fractional iteration start would result in the compositor placing the element in an incorrect position before the animation has started. When computing the trimmed time/iteration time of an animation that has not yet started, the fractional iteration start is taken into account. BUG=423202 Committed: https://crrev.com/5cb641f14c9cffe102e2732ed1b3e386629f3f9b Cr-Commit-Position: refs/heads/master@{#299626}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M cc/animation/animation.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/animation/animation_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
samli
6 years, 2 months ago (2014-10-14 22:33:46 UTC) #4
ajuma
lgtm Please update the description to include what the patch does (e.g. that it takes ...
6 years, 2 months ago (2014-10-14 23:17:08 UTC) #5
samli
Updated comment and description.
6 years, 2 months ago (2014-10-14 23:30:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652813003/20001
6 years, 2 months ago (2014-10-14 23:32:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 02:17:59 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 02:19:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cb641f14c9cffe102e2732ed1b3e386629f3f9b
Cr-Commit-Position: refs/heads/master@{#299626}

Powered by Google App Engine
This is Rietveld 408576698