Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 652813002: [Telemetry] Merge _PageState to _RunState in page_runner.py (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Merge _PageState to _RunState in page_runner.py The motivation behind this merge is to create a single place that manages the browser & tab state before running multiple page, before running each page, after running each page, and after running multiple pages. Next patches will refactor this _RunState object to SharedPageState as planned in https://docs.google.com/a/google.com/document/d/1on2ATPE8Y7a0SLcd4cl3nAiSthVpVLU6OoVZatEavEA/edit. Besides the merging of PageState and RunState, this patch also renames _RunPage -> _RunPageAndProcessErrorIfNeeded and _PrepareAndRunPage -> _RunPageAndRetryRunIfNeeded to clear up the distinction what each of these functions does. BUG=418278 Committed: https://crrev.com/32943ec796c9c235fae4048b00a73bb3fcd140f9 Cr-Commit-Position: refs/heads/master@{#299425}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M tools/telemetry/telemetry/page/page_runner.py View 10 chunks +52 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nednguyen
6 years, 2 months ago (2014-10-13 20:41:11 UTC) #4
dtu
lgtm
6 years, 2 months ago (2014-10-14 00:08:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652813002/50001
6 years, 2 months ago (2014-10-14 01:27:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:50001)
6 years, 2 months ago (2014-10-14 03:50:55 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:51:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32943ec796c9c235fae4048b00a73bb3fcd140f9
Cr-Commit-Position: refs/heads/master@{#299425}

Powered by Google App Engine
This is Rietveld 408576698