Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 652793004: Always use --host-resolver-rules Chrome flag with ChromeOS (Closed)

Created:
6 years, 2 months ago by slamm
Modified:
6 years, 2 months ago
Reviewers:
nednguyen, achuithb
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always use --host-resolver-rules Chrome flag with ChromeOS From the bug description: A recent change inadvertently changed the flags that ChromeOS had used. The change: Handle replay args within replay module. https://codereview.chromium.org/617043003/ Made that the --host-resolver-rules is not added when --netsim is used. However, prior to the change, --host-resolver-rules was always used with ChromeOS. I am unsure why ChromeOS always uses that flag. However, it matches how the cros_browser_backend always sets the DNS ports to None. BUG=423092 Committed: https://crrev.com/a61c2280f97f17f01c4020c8e880dfc6e8fd1535 Cr-Commit-Position: refs/heads/master@{#299537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 3 chunks +15 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
slamm
Restore ChromeOS behavior of always using --host-resolver-rules. Does anyone happen to know why ChromeOS always ...
6 years, 2 months ago (2014-10-13 21:14:36 UTC) #2
nednguyen
6 years, 2 months ago (2014-10-13 21:16:38 UTC) #4
slamm
Hi Achuith, PTAL. It is the same change that you LGTM'd in my other CL: ...
6 years, 2 months ago (2014-10-14 17:16:57 UTC) #6
achuithb
lgtm I'm not too familiar with this code, but will keep an eye out for ...
6 years, 2 months ago (2014-10-14 18:39:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652793004/1
6 years, 2 months ago (2014-10-14 19:01:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 20:28:53 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 20:30:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a61c2280f97f17f01c4020c8e880dfc6e8fd1535
Cr-Commit-Position: refs/heads/master@{#299537}

Powered by Google App Engine
This is Rietveld 408576698