Close the select box when the parent RWHVA loses focus

Close the select box when the parent RWHVA loses focus

BUG=422264, 414550
TEST=RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus

Committed: https://crrev.com/1f909ee8c8ae5cbc92416482374d2228f087684c
Cr-Commit-Position: refs/heads/master@{#301108}

[pkotwicz, 2014-10-13 20:50:27]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-10-13 20:51:11]

Patchset #1 (id:60001) has been deleted

[pkotwicz, 2014-10-13 20:56:45]

Patchset #1 (id:90001) has been deleted

[pkotwicz, 2014-10-13 20:59:19]

pkotwicz@chromium.org changed reviewers:
+ tkent@chromium.org

[pkotwicz, 2014-10-13 20:59:19]

tkent@ PTAL. In particular, do you expect this new logic to break anything?

This logic should live in Chrome (as opposed to blink). The select box should
close if a different browser window opens a JS alert (because JS alerts are app
modal) or if a system modal dialog opens on CrOS.

[tkent, 2014-10-15 01:32:14]

The change looks reasonable though I'm not familiar with these files.

[pkotwicz, 2014-10-15 02:44:45]

tkent@ do you have a suggestion as to who would be a good person (apart for ben@
for OWNERS) to look at this change?

[tkent, 2014-10-15 08:05:42]

On 2014/10/15 02:44:45, pkotwicz wrote:
> tkent@ do you have a suggestion as to who would be a good person (apart for
ben@
> for OWNERS) to look at this change?

Unfortunately I don't know.  Please find an active developer by "git blame".

[pkotwicz, 2014-10-15 15:06:02]

pkotwicz@chromium.org changed reviewers:
+ ben@chromium.org

[pkotwicz, 2014-10-15 15:06:03]

Ben, can you please take a look?

[pkotwicz, 2014-10-16 15:05:03]

Ben, Ping?

[Ben Goodger (Google), 2014-10-20 20:29:26]

lgtm

[pkotwicz, 2014-10-23 14:33:42]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-23 14:34:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652793003/120001

[commit-bot: I haz the power, 2014-10-23 15:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 15:33:59]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-23 16:52:10]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-23 16:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652793003/120001

[commit-bot: I haz the power, 2014-10-23 18:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 18:23:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-24 14:58:11]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-24 14:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652793003/170001

[commit-bot: I haz the power, 2014-10-24 15:54:09]

Committed patchset #2 (id:170001)

[commit-bot: I haz the power, 2014-10-24 15:54:50]

Patchset 2 (id:??) landed as
https://crrev.com/1f909ee8c8ae5cbc92416482374d2228f087684c
Cr-Commit-Position: refs/heads/master@{#301108}

[yzshen1, 2014-10-24 16:56:21]

A revert of this CL (patchset #2 id:170001) has been created in
https://codereview.chromium.org/663483005/ by yzshen@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Tests (dbg)(1):
RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (run #1):
[ RUN      ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus
Xlib:  extension "RANDR" missing on display ":9".
../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:875:
Failure
Value of: observer.destroyed()
  Actual: false
Expected: true
[  FAILED  ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (10
ms).