Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 652743012: Speculatively re-enabling ServiceWorkerBrowserTest.Reload and ServiceWorkerBlackBoxBrowserTest.Regi… (Closed)

Created:
6 years, 2 months ago by Kunihiko Sakamoto
Modified:
6 years, 2 months ago
Reviewers:
falken, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Speculatively re-enabling ServiceWorkerBrowserTest.Reload and ServiceWorkerBlackBoxBrowserTest.Registration This doesn't reproduce neither locally nor on trybots after running all night, and old test logs are inaccessible. I'm going to re-enable these and see if they're still flaking. BUG=387045, 393486 Committed: https://crrev.com/4ead2129f01476c5f1878dab81495c5e1f327979 Cr-Commit-Position: refs/heads/master@{#300403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
6 years, 2 months ago (2014-10-21 01:35:19 UTC) #2
falken
lgtm LGTM
6 years, 2 months ago (2014-10-21 01:39:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652743012/1
6 years, 2 months ago (2014-10-21 01:41:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 02:44:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 03:11:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ead2129f01476c5f1878dab81495c5e1f327979
Cr-Commit-Position: refs/heads/master@{#300403}

Powered by Google App Engine
This is Rietveld 408576698