src/scanner.h - Issue 652743005: Correctly expand literal buffer for surrogate pairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scanner.h

Issue 652743005: Correctly expand literal buffer for surrogate pairs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scanner.h

diff --git a/src/scanner.h b/src/scanner.h

index d40c6266b729b7edc5a97b1e4057de42a93a0d04..7f35e719da783767d55c96ffe04d29d8b7bb12c3 100644

--- a/src/scanner.h

+++ b/src/scanner.h

@@ -219,6 +219,7 @@ class LiteralBuffer {

*reinterpret_cast<uint16_t*>(&backing_store_[position_]) =

unibrow::Utf16::LeadSurrogate(code_unit);

position_ += kUC16Size;

+ if (position_ >= backing_store_.length()) ExpandBuffer();

*reinterpret_cast<uint16_t*>(&backing_store_[position_]) =

unibrow::Utf16::TrailSurrogate(code_unit);

position_ += kUC16Size;

« no previous file with comments | « no previous file | no next file » | no next file with comments »