Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652743003: Fix update and enrollment flow (Closed)

Created:
6 years, 2 months ago by achuithb
Modified:
6 years, 2 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

* Transition host to STAGE_UPDATING after pairing. * Add enrollment status to proto * Remove stages not handled by HostPairingController, and ControllerPairingController. * UpdateScreen sends update status via remora_controller. * EnrollmentScreen sends enrollment status via remora_controller. * Remove auth_token_ from EnrollmentScreen. * Rename to shark_controller and remora_controller in WizardController. * Remove get_initial_status_ from BluetoothControllerPairingController. Committed: https://crrev.com/ebd853b376cb58ea120aca3617b86ae6db8785d2 Cr-Commit-Position: refs/heads/master@{#299422}

Patch Set 1 #

Patch Set 2 : fix build break #

Total comments: 2

Patch Set 3 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -142 lines) Patch
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 2 chunks +5 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/login/screens/mock_update_screen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 1 2 4 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 7 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.h View 2 chunks +1 line, -1 line 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 3 chunks +30 lines, -21 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 5 chunks +61 lines, -20 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.h View 2 chunks +8 lines, -7 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/pairing/host_pairing_controller.h View 2 chunks +11 lines, -2 lines 0 comments Download
M components/pairing/pairing_api.proto View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
achuithb
I've listed the set of changes in the description. I'm open to breaking this up ...
6 years, 2 months ago (2014-10-13 20:24:41 UTC) #2
Zachary Kuznia
LGTM with nit. https://codereview.chromium.org/652743003/diff/210001/chrome/browser/chromeos/login/screens/update_screen.h File chrome/browser/chromeos/login/screens/update_screen.h (right): https://codereview.chromium.org/652743003/diff/210001/chrome/browser/chromeos/login/screens/update_screen.h#newcode38 chrome/browser/chromeos/login/screens/update_screen.h:38: pairing_chromeos::HostPairingController* remora_controller); Fix the indent here.
6 years, 2 months ago (2014-10-14 00:23:42 UTC) #3
achuithb
Thanks! https://codereview.chromium.org/652743003/diff/210001/chrome/browser/chromeos/login/screens/update_screen.h File chrome/browser/chromeos/login/screens/update_screen.h (right): https://codereview.chromium.org/652743003/diff/210001/chrome/browser/chromeos/login/screens/update_screen.h#newcode38 chrome/browser/chromeos/login/screens/update_screen.h:38: pairing_chromeos::HostPairingController* remora_controller); On 2014/10/14 00:23:42, Zachary Kuznia wrote: ...
6 years, 2 months ago (2014-10-14 01:42:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652743003/150002
6 years, 2 months ago (2014-10-14 01:43:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:150002)
6 years, 2 months ago (2014-10-14 03:48:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:49:53 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ebd853b376cb58ea120aca3617b86ae6db8785d2
Cr-Commit-Position: refs/heads/master@{#299422}

Powered by Google App Engine
This is Rietveld 408576698