android_webview/native/aw_contents.cc - Issue 65273002: Add a mechanism to pause and resume geolocation requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 65273002: Add a mechanism to pause and resume geolocation requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add new test case, fix a bug :) Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/LocationProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index f949da08442c00b993d22b23376396b90c8c73fb..de4a713b39f2feaa288b9bfa4ab65e52b7adb6ce 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -733,11 +733,13 @@ void AwContents::SetWindowVisibility(JNIEnv* env, jobject obj, bool visible) {

void AwContents::SetIsPaused(JNIEnv* env, jobject obj, bool paused) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

browser_view_renderer_->SetIsPaused(paused);

- if (paused) {

- ContentViewCore* cvc =

- ContentViewCore::FromWebContents(web_contents_.get());

- if (cvc)

+ ContentViewCore* cvc =

+ ContentViewCore::FromWebContents(web_contents_.get());

+ if (cvc) {

+ cvc->PauseOrResumeGeolocation(paused);

+ if (paused) {

cvc->PauseVideo();

+ }

}