Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: sync/internal_api/attachments/attachment_store_handle_unittest.cc

Issue 652723003: Implementation of OnDiskAttachmentStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More updates Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_store_handle_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_store_handle_unittest.cc b/sync/internal_api/attachments/attachment_store_handle_unittest.cc
index a282c607977ab5719acf04bba0ab6175f255056f..0ce411f0b5d97b79a27059f7a6d630fbab103352 100644
--- a/sync/internal_api/attachments/attachment_store_handle_unittest.cc
+++ b/sync/internal_api/attachments/attachment_store_handle_unittest.cc
@@ -79,17 +79,13 @@ class AttachmentStoreHandleTest : public testing::Test {
backend.Pass(), base::ThreadTaskRunnerHandle::Get());
}
- static void ReadDone(const AttachmentStore::Result& result,
- scoped_ptr<AttachmentMap> attachments,
- scoped_ptr<AttachmentIdList> unavailable_attachments) {
+ static void DoneWithResult(const AttachmentStore::Result& result) {
NOTREACHED();
}
- static void WriteDone(const AttachmentStore::Result& result) {
- NOTREACHED();
- }
-
- static void DropDone(const AttachmentStore::Result& result) {
+ static void ReadDone(const AttachmentStore::Result& result,
+ scoped_ptr<AttachmentMap> attachments,
+ scoped_ptr<AttachmentIdList> unavailable_attachments) {
NOTREACHED();
}
@@ -126,13 +122,13 @@ TEST_F(AttachmentStoreHandleTest, MethodsCalled) {
EXPECT_EQ(read_call_count_, 1);
attachment_store_handle_->Write(
- attachments, base::Bind(&AttachmentStoreHandleTest::WriteDone));
+ attachments, base::Bind(&AttachmentStoreHandleTest::DoneWithResult));
EXPECT_EQ(write_call_count_, 0);
RunMessageLoop();
EXPECT_EQ(write_call_count_, 1);
attachment_store_handle_->Drop(
- ids, base::Bind(&AttachmentStoreHandleTest::DropDone));
+ ids, base::Bind(&AttachmentStoreHandleTest::DoneWithResult));
EXPECT_EQ(drop_call_count_, 0);
RunMessageLoop();
EXPECT_EQ(drop_call_count_, 1);
« no previous file with comments | « sync/api/attachments/attachment_store.cc ('k') | sync/internal_api/attachments/attachment_store_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698