Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 652663003: Adding MeterRole in blink to support MSAA+IA2 and AX roles for meter tag in Chromium. (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding MeterRole in blink to support MSAA+IA2 and AX roles for meter tag in Chromium. According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html meter tag should have MSAA+IA2 Role as ROLE_SYSTEM_PROGRESSBAR and AX role as AXGroup and Role description as "group" BUG=421376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
shreeramk
Please review. This would be followed up by Chromium side CL which will take care ...
6 years, 2 months ago (2014-10-13 16:55:57 UTC) #2
dmazzoni
I'm suspicious of the spec - why should it be AXGroup on Mac? That looks ...
6 years, 2 months ago (2014-10-13 17:44:00 UTC) #3
shreeramk
On 2014/10/13 17:44:00, dmazzoni wrote: > I'm suspicious of the spec - why should it ...
6 years, 2 months ago (2014-10-13 18:03:42 UTC) #4
dmazzoni
On 2014/10/13 18:03:42, shreeram.k wrote: > I think <progress> tag(which represents the progress of a ...
6 years, 2 months ago (2014-10-13 21:42:59 UTC) #5
dmazzoni
lgtm
6 years, 2 months ago (2014-10-13 21:43:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652663003/1
6 years, 2 months ago (2014-10-13 21:44:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31578)
6 years, 2 months ago (2014-10-13 23:58:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652663003/1
6 years, 2 months ago (2014-10-14 03:38:04 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:39:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183638

Powered by Google App Engine
This is Rietveld 408576698