Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 652663002: change OVERRIDE to override in dbus/object_manager.h in comment (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
keybuk, stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

change OVERRIDE to override in dbus/object_manager.h in comment TBR=keybuk@chromium.org BUG=417463 Committed: https://crrev.com/a10ba5389195689ad456b33eda067234ef4acacc Cr-Commit-Position: refs/heads/master@{#299962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dbus/object_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Mostyn Bramley-Moore
@keybuk: can you please give this comment-only change a green light?
6 years, 2 months ago (2014-10-13 09:11:11 UTC) #2
Mostyn Bramley-Moore
Changing this into TBR=keybuk since this is just a comment.
6 years, 2 months ago (2014-10-14 07:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652663002/1
6 years, 2 months ago (2014-10-14 07:41:04 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-14 07:41:07 UTC) #7
Mostyn Bramley-Moore
Adding another owner... @stevenjb: can you please give this a thumbs-up?
6 years, 2 months ago (2014-10-16 19:00:57 UTC) #9
stevenjb
lgtm
6 years, 2 months ago (2014-10-16 19:11:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652663002/1
6 years, 2 months ago (2014-10-16 19:13:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 19:50:24 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:53:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a10ba5389195689ad456b33eda067234ef4acacc
Cr-Commit-Position: refs/heads/master@{#299962}

Powered by Google App Engine
This is Rietveld 408576698