Issue 652643002: [turbofan] remove graph from InstructionSequence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652643002: [turbofan] remove graph from InstructionSequence (Closed)

Created:
6 years, 2 months ago by dcarney

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] remove graph from InstructionSequence R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24545

Patch Set 2 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
M	src/compiler/code-generator.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/instruction.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/compiler/instruction.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/compiler/instruction-selector.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/instruction-selector.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/instruction-selector-impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/compiler/test-instruction.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

LGTM with nit. https://codereview.chromium.org/652643002/diff/110001/src/compiler/instruction.h File src/compiler/instruction.h (right): https://codereview.chromium.org/652643002/diff/110001/src/compiler/instruction.h#newcode770 src/compiler/instruction.h:770: int ValueCount() const { return node_count_; ...

6 years, 2 months ago (2014-10-13 08:01:51 UTC) #4

dcarney

6 years, 2 months ago (2014-10-13 08:09:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:170001) manually as 24545 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 652643002: [turbofan] remove graph from InstructionSequence (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages