ui/base/ui_base_paths.cc - Issue 652623005: Revert of Eliminate silently letting errors pass on pak loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ui_base_paths.cc

Issue 652623005: Revert of Eliminate silently letting errors pass on pak loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ui_base_paths.cc

diff --git a/ui/base/ui_base_paths.cc b/ui/base/ui_base_paths.cc

index 4c39024fb282b266a2277193f6cc2cc2a3ec8c45..083315d422833c6d7c59ef1d93fddc9ddb12f51e 100644

--- a/ui/base/ui_base_paths.cc

+++ b/ui/base/ui_base_paths.cc

@@ -79,11 +79,7 @@

// This cannot be done as a static initializer sadly since Visual Studio will

// eliminate this object file if there is no direct entry point into it.

void RegisterPathProvider() {

- static bool registered = false;

- if (!registered) {

- PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);

- registered = true;

- }

+ PathService::RegisterProvider(PathProvider, PATH_START, PATH_END);

}

} // namespace ui

« no previous file with comments | « ui/base/ui_base_paths.h ('k') | ui/base/ui_base_tests.gypi » ('j') | no next file with comments »