Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 652613003: Fix DesktopWindowTreeHostX11Test.Shape on Unity (Closed)

Created:
6 years, 2 months ago by pkotwicz
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix DesktopWindowTreeHostX11Test.Shape on Unity BUG=423555 TEST=None Committed: https://crrev.com/b7958f869b00cc2f004b05ec4e787119204e441d Cr-Commit-Position: refs/heads/master@{#299946}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
Elliot, can you please take a look? The test was failing on Unity because we ...
6 years, 2 months ago (2014-10-16 01:32:22 UTC) #2
Matt Giuca
Thanks for fixing this, Peter. Did you figure out why the tests were passing on ...
6 years, 2 months ago (2014-10-16 06:39:17 UTC) #4
pkotwicz
I did not look into why the test was passing on the trybots. The test ...
6 years, 2 months ago (2014-10-16 14:26:01 UTC) #5
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-10-16 17:32:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652613003/20001
6 years, 2 months ago (2014-10-16 18:25:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-16 19:02:32 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:05:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7958f869b00cc2f004b05ec4e787119204e441d
Cr-Commit-Position: refs/heads/master@{#299946}

Powered by Google App Engine
This is Rietveld 408576698