Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 652603002: Fix typedarray tests (Closed)

Created:
6 years, 2 months ago by xuq
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix typedarray tests. 1. Fixed typo. lenght -> length. Arbitary -> Arbitrary. 2. TypedArray DataView property getters should throw TypeError when called on incompatible types. 3. Should not use integers as keys in the arbitrary-properties test. R=dslomov@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24551

Patch Set 1 : Fix typo: lenght -> length #

Patch Set 2 : DataView property getters should throw TypeError when called on incompatible types. #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M test/mjsunit/harmony/typedarrays.js View 1 2 3 4 4 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
xuq
6 years, 2 months ago (2014-10-13 02:01:13 UTC) #4
Yang
LGTM. Thanks you for submitting this fix! I'll forward to Dmitry as this is his ...
6 years, 2 months ago (2014-10-13 06:46:36 UTC) #6
Dmitry Lomov (no reviews)
On 2014/10/13 06:46:36, Yang wrote: > LGTM. Thanks you for submitting this fix! I'll forward ...
6 years, 2 months ago (2014-10-13 09:33:21 UTC) #7
Dmitry Lomov (no reviews)
(I'll land for you)
6 years, 2 months ago (2014-10-13 09:34:19 UTC) #8
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-13 09:48:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:200001) manually as 24551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698