Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 6526023: Merge 78548 - 2011-02-15 Gavin Peters <gavinp@chromium.org>... (Closed)

Created:
9 years, 10 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
Charlie Reis, tonyg, gavinp
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 78548 - 2011-02-15 Gavin Peters <gavinp@chromium.org>; Reviewed by Antti Koivisto. SharedBuffer::buffer() does not do what you think. https://bugs.webkit.org/show_bug.cgi?id=54420 No new tests. * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64): * platform/SharedBuffer.h: * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode): * platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78615

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +19 lines, -1 line 1 comment Download
M Source/WebCore/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/SharedBuffer.h View 2 chunks +7 lines, -4 lines 0 comments Download
M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
9 years, 10 months ago (2011-02-15 22:26:56 UTC) #1
gavinp
LGTM, that's the resolution in InspectorResourceAgent.cpp that I think works.
9 years, 10 months ago (2011-02-15 22:29:44 UTC) #2
Charlie Reis
9 years, 10 months ago (2011-02-15 22:30:42 UTC) #3
http://codereview.chromium.org/6526023/diff/1/Source/WebCore/ChangeLog
File Source/WebCore/ChangeLog (left):

http://codereview.chromium.org/6526023/diff/1/Source/WebCore/ChangeLog#oldcode1
Source/WebCore/ChangeLog:1: -2011-02-15  Charlie Reis  <creis@chromium.org>
Did you mean to delete this line?  It looks like the change is attributing my
change to Dirk.

Powered by Google App Engine
This is Rietveld 408576698