Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 652583002: remove unused Leak() function (Closed)

Created:
6 years, 2 months ago by hendrikw
Modified:
6 years, 2 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Remove unused Leak() function I stumbled on this while working on the dff change. It looks like the only place this function is used is in the test. I removed the test as well, since its only purpose was to check that calling leak would indeed leak. Committed: https://crrev.com/ae18399fc109d4b6740c819743a8028729151b3a Cr-Commit-Position: refs/heads/master@{#300321}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : removed test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -43 lines) Patch
M cc/resources/scoped_resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/scoped_resource.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/scoped_resource_unittest.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hendrikw
Remove dead code, PTAL thanks!
6 years, 2 months ago (2014-10-20 17:30:24 UTC) #2
reveman
thanks, lgtm
6 years, 2 months ago (2014-10-20 18:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652583002/70001
6 years, 2 months ago (2014-10-20 18:03:56 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:70001)
6 years, 2 months ago (2014-10-20 20:23:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:24:17 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae18399fc109d4b6740c819743a8028729151b3a
Cr-Commit-Position: refs/heads/master@{#300321}

Powered by Google App Engine
This is Rietveld 408576698