Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 652543007: Add support for a target new space size (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add support for a target new space size When this flag is set, we will commit additional pages up until the target size before doing a scavenge. I made sure that all tests pass when a target size of 16MB is set. BUG=v8:3626 R=ulan@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24790

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -16 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +28 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +12 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 9 chunks +65 lines, -7 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +22 lines, -6 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-21 14:47:16 UTC) #1
ulan
lgtm https://codereview.chromium.org/652543007/diff/1/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/652543007/diff/1/src/heap/spaces.cc#newcode1312 src/heap/spaces.cc:1312: V8::FatalProcessOutOfMemory("Failed to grow new space."); All V8::FatalProcessOutOfMemory here ...
6 years, 2 months ago (2014-10-21 15:01:50 UTC) #2
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-22 06:58:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698