Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 652543005: Add bisect-config-trying script and a few example configs. (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add bisect-config-trying script and a few example configs. This is my initial attempt at the script suggested in http://crbug.com/415890. BUG=415890 Committed: https://crrev.com/08ed0eb821d13be68050cc55fcbcba99902fbc10 Cr-Commit-Position: refs/heads/master@{#301409}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Respond to Annie's comments and modify sample configs. #

Total comments: 6

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : Use absolute path for SCRIPT_DIR. #

Patch Set 6 : Add copyright header #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -0 lines) Patch
A tools/auto_bisect/configs/android.bisect.blink_perf.cfg View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/android.perf_test.sunspider.cfg View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/linux.bisect.page_cycler.cfg View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/linux.perf_test.tab_switching.cfg View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/mac.bisect.blink_perf.cfg View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/try.py View 1 2 3 4 5 1 chunk +157 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/win.bisect.blink_perf.cfg View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A tools/auto_bisect/configs/win.perf_test.kraken.cfg View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (6 generated)
qyearsley
Hey everyone, I'm not quite sure who is best to put as the main reviewer ...
6 years, 2 months ago (2014-10-21 01:13:03 UTC) #2
sullivan
https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py#newcode107 tools/auto_bisect/configs/try.py:107: _Run(['git', 'try', '--svn_repo', SVN_URL, '--bot', bot_name]) The output of ...
6 years, 2 months ago (2014-10-21 14:27:44 UTC) #3
Sergiy Byelozyorov
awesome work... https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py#newcode109 tools/auto_bisect/configs/try.py:109: _Run(['git', 'reset', '--hard', 'HEAD~1']) On 2014/10/21 14:27:42, ...
6 years, 2 months ago (2014-10-21 19:04:37 UTC) #4
qyearsley
https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/1/tools/auto_bisect/configs/try.py#newcode107 tools/auto_bisect/configs/try.py:107: _Run(['git', 'try', '--svn_repo', SVN_URL, '--bot', bot_name]) On 2014/10/21 14:27:42, ...
6 years, 2 months ago (2014-10-21 19:06:26 UTC) #5
Sergiy Byelozyorov
https://codereview.chromium.org/652543005/diff/20001/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/20001/tools/auto_bisect/configs/try.py#newcode46 tools/auto_bisect/configs/try.py:46: parser.add_argument('--filter', help='Filter config filenames to use.') Please explain better ...
6 years, 2 months ago (2014-10-21 19:15:31 UTC) #6
Sergiy Byelozyorov
lgtm with comments
6 years, 2 months ago (2014-10-21 19:16:25 UTC) #7
qyearsley
https://codereview.chromium.org/652543005/diff/20001/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/20001/tools/auto_bisect/configs/try.py#newcode46 tools/auto_bisect/configs/try.py:46: parser.add_argument('--filter', help='Filter config filenames to use.') On 2014/10/21 19:15:30, ...
6 years, 2 months ago (2014-10-21 19:21:24 UTC) #8
Sergiy Byelozyorov
https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/try.py File tools/auto_bisect/configs/try.py (right): https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/try.py#newcode23 tools/auto_bisect/configs/try.py:23: SCRIPT_DIR = os.path.dirname(__file__) SCRIPT_DIR = os.path.abspath(os.path.dirname(__file__)) Otherwise when run ...
6 years, 2 months ago (2014-10-21 19:24:42 UTC) #9
Sergiy Byelozyorov
And (hopefully) last comment - as suggested by sullivan@, please extract the build number from ...
6 years, 2 months ago (2014-10-21 19:27:33 UTC) #10
Sergiy Byelozyorov
On 2014/10/21 19:27:33, Sergiy Byelozyorov wrote: > And (hopefully) last comment - as suggested by ...
6 years, 2 months ago (2014-10-21 19:35:50 UTC) #11
prasadv
Why windows config is not considered? https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/android.bisect.blink_perf.cfg File tools/auto_bisect/configs/android.bisect.blink_perf.cfg (right): https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/android.bisect.blink_perf.cfg#newcode10 tools/auto_bisect/configs/android.bisect.blink_perf.cfg:10: 'repeat_count': '10', I ...
6 years, 2 months ago (2014-10-21 23:44:47 UTC) #12
qyearsley
https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/android.bisect.blink_perf.cfg File tools/auto_bisect/configs/android.bisect.blink_perf.cfg (right): https://codereview.chromium.org/652543005/diff/40001/tools/auto_bisect/configs/android.bisect.blink_perf.cfg#newcode10 tools/auto_bisect/configs/android.bisect.blink_perf.cfg:10: 'repeat_count': '10', On 2014/10/21 23:44:47, prasadv wrote: > I ...
6 years, 2 months ago (2014-10-23 02:51:01 UTC) #13
qyearsley
Hey guys, for this script, WDYT about having it invoked with sample scripts as input ...
6 years, 2 months ago (2014-10-23 18:09:08 UTC) #14
chromium-reviews
I like this idea. On Thu Oct 23 2014 at 11:09:10 AM <qyearsley@chromium.org> wrote: > ...
6 years, 2 months ago (2014-10-23 21:07:42 UTC) #15
prasadv
lgtm
6 years, 2 months ago (2014-10-23 22:47:43 UTC) #16
Sergiy Byelozyorov
Can this be commit now please?
6 years, 1 month ago (2014-10-27 12:38:11 UTC) #17
qyearsley
On 2014/10/27 12:38:11, Sergiy Byelozyorov wrote: > Can this be commit now please? Okay -- ...
6 years, 1 month ago (2014-10-27 16:09:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652543005/80001
6 years, 1 month ago (2014-10-27 16:10:05 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20269)
6 years, 1 month ago (2014-10-27 16:18:09 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652543005/100001
6 years, 1 month ago (2014-10-27 16:40:48 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78927) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/23248) win_chromium_x64_rel ...
6 years, 1 month ago (2014-10-27 16:50:34 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652543005/120001
6 years, 1 month ago (2014-10-27 17:57:40 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 1 month ago (2014-10-27 19:32:02 UTC) #29
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:33:07 UTC) #30
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/08ed0eb821d13be68050cc55fcbcba99902fbc10
Cr-Commit-Position: refs/heads/master@{#301409}

Powered by Google App Engine
This is Rietveld 408576698