Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 65253002: Changes to make SkPDiff more robost. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Changes to make SkPDiff more robost. bitmap_to_cielab now returns a boolean. Instead of asserting that the config is 8888, copy to 8888 (and return false on failure). This allows skpdiff to work on Index8 bitmaps (without changing the code that does the real work). If it returns false, do not attempt to create a pmetric. In pmetric, exit early if maxLevels is <= 2, since this would crash later in the function (creation of an ImageL3D if maxLevels is 0, and then the creation of an array of a negative number of entries). maxLevels is small if the width or height of the image is small (i.e. a bitmap with width 1 has maxLevels of 0). R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=12239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M tools/skpdiff/SkPMetric.cpp View 4 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Derek, I don't know if your other change will obsolete this, but I needed to ...
7 years, 1 month ago (2013-11-07 20:30:29 UTC) #1
djsollen
lgtm
7 years, 1 month ago (2013-11-07 21:44:33 UTC) #2
scroggo
7 years, 1 month ago (2013-11-12 14:41:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698