Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/trusted/debug_stub/win/thread_impl.cc

Issue 6525058: Reverting: Several changes to fix debug_stub:... (issue6489005)... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/gdb_rsp/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/debug_stub/win/thread_impl.cc
===================================================================
--- src/trusted/debug_stub/win/thread_impl.cc (revision 4321)
+++ src/trusted/debug_stub/win/thread_impl.cc (working copy)
@@ -309,21 +309,6 @@
uint32_t id = static_cast<uint32_t>(GetCurrentThreadId());
Thread* thread = static_cast<Thread*>(Acquire(id));
- // This 2 lineas are a fix for the bug:
- // 366: Linux GDB doesn't work for Chrome
- // http://code.google.com/p/nativeclient/issues/detail?id=366
- // When debug stub thread opens socket to listen (for RSP debugger),
- // it triggers some component to send DBG_PRINTEXCEPTION(with string
- // "swi_lsp: non-browser app; disable"), then VEH handler goes into wait
- // for debugger to resolve exception.
- // But debugger is not connected, and debug thread is not listening on
- // connection! It get stuck.
- // Ignoring this exception - for now - helps debug stub start on chrome.
- // Now it can listen on RSP connection and can get debugger connected etc.
- if (DBG_PRINTEXCEPTION_C == ep->ExceptionRecord->ExceptionCode) {
- return EXCEPTION_CONTINUE_EXECUTION;
- }
-
// If we are not tracking this thread, then ignore it
if (NULL == thread) return EXCEPTION_CONTINUE_SEARCH;
« no previous file with comments | « no previous file | src/trusted/gdb_rsp/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698