Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6525: Calculate string hash during flattening. (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Calculate string hash during flattening and convert flat strings to symbols.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -40 lines) Patch
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/objects.h View 4 chunks +55 lines, -1 line 0 comments Download
M src/objects.cc View 7 chunks +80 lines, -37 lines 1 comment Download
M src/objects-inl.h View 1 chunk +59 lines, -0 lines 1 comment Download
M src/runtime.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
12 years, 2 months ago (2008-10-07 08:42:03 UTC) #1
Erik Corry
http://codereview.chromium.org/6525/diff/1/4 File src/objects-inl.h (right): http://codereview.chromium.org/6525/diff/1/4#newcode2123 Line 2123: if (array_index_ > 429496729U - ((d > 5) ...
12 years, 2 months ago (2008-10-07 10:04:34 UTC) #2
Erik Corry
12 years, 2 months ago (2008-10-07 10:04:48 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698