Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2131)

Unified Diff: chrome/browser/supervised_user/permission_request_creator_apiary.h

Issue 652473004: Standardize usage of virtual/override/final in chrome/browser/supervised_user/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/permission_request_creator_apiary.h
diff --git a/chrome/browser/supervised_user/permission_request_creator_apiary.h b/chrome/browser/supervised_user/permission_request_creator_apiary.h
index 9d1828bdd94a0a2b12f0d1cc91c138562d129f4d..c742c817f483f26e9d6c9076cab49e9d4b21b341 100644
--- a/chrome/browser/supervised_user/permission_request_creator_apiary.h
+++ b/chrome/browser/supervised_user/permission_request_creator_apiary.h
@@ -35,16 +35,15 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
scoped_ptr<SupervisedUserSigninManagerWrapper> signin_wrapper,
net::URLRequestContextGetter* context,
const GURL& apiary_url);
- virtual ~PermissionRequestCreatorApiary();
+ ~PermissionRequestCreatorApiary() override;
static scoped_ptr<PermissionRequestCreator> CreateWithProfile(
Profile* profile, const GURL& apiary_url);
// PermissionRequestCreator implementation:
- virtual bool IsEnabled() const override;
- virtual void CreatePermissionRequest(
- const GURL& url_requested,
- const SuccessCallback& callback) override;
+ bool IsEnabled() const override;
+ void CreatePermissionRequest(const GURL& url_requested,
+ const SuccessCallback& callback) override;
void set_url_fetcher_id_for_testing(int id) { url_fetcher_id_ = id; }
@@ -53,14 +52,14 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
typedef ScopedVector<Request>::iterator RequestIterator;
// OAuth2TokenService::Consumer implementation:
- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override;
- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override;
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override;
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override;
// net::URLFetcherDelegate implementation.
- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
std::string GetApiScopeToUse() const;

Powered by Google App Engine
This is Rietveld 408576698