Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 652403005: Support assignment of locals in analyzer2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer2dart/lib/src/identifier_semantics.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index d22d3aca17ca13566d3b91f5b37454a844a06e8d..9601cb82087a4efc85fb7c9db9b3dd45b93e3bcb 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -46,8 +46,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
function.parameters.forEach((analyzer.ParameterElement parameter) {
// TODO(johnniwinther): Support "closure variables", that is variables
// accessed from an inner function.
- irBuilder.createParameter(converter.convertElement(parameter),
- isClosureVariable: false);
+ irBuilder.createParameter(converter.convertElement(parameter));
});
// Visit the body directly to avoid processing the signature as
// expressions.
@@ -191,11 +190,43 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
initialValue: initialValue);
}
- ir.Primitive handleLocalAccess(AstNode node, AccessSemantics semantics) {
+ dart2js.Element getLocal(AstNode node, AccessSemantics semantics) {
analyzer.Element element = semantics.element;
dart2js.Element target = converter.convertElement(element);
assert(invariant(node, target.isLocal, '$target expected to be local.'));
- return irBuilder.buildLocalGet(target);
+ return target;
+ }
+
+ ir.Primitive handleLocalAccess(AstNode node, AccessSemantics semantics) {
+ return irBuilder.buildLocalGet(getLocal(node, semantics));
+ }
+
+ ir.Primitive handleLocalAssignment(AssignmentExpression node,
+ AccessSemantics semantics) {
+ if (node.operator.lexeme != '=') {
+ return giveUp(node, 'Assignment operator: ${node.operator.lexeme}');
+ }
+ return irBuilder.buildLocalSet(
+ getLocal(node, semantics),
+ build(node.rightHandSide));
+ }
+
+ @override
+ ir.Node visitAssignmentExpression(AssignmentExpression node) {
+ // Avoid eager visiting of left and right hand side.
+ return handleAssignmentExpression(node);
+ }
+
+ @override
+ ir.Node visitLocalVariableAssignment(AssignmentExpression node,
+ AccessSemantics semantics) {
+ return handleLocalAssignment(node, semantics);
+ }
+
+ @override
+ ir.Node visitParameterAssignment(AssignmentExpression node,
+ AccessSemantics semantics) {
+ return handleLocalAssignment(node, semantics);
}
@override
« no previous file with comments | « no previous file | pkg/analyzer2dart/lib/src/identifier_semantics.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698