[Clean up] Expose ConnectToServiceInsecurely as a BluetoothDevice API on all platforms.

[Clean up] Expose ConnectToServiceInsecurely as a BluetoothDevice API on all platforms.

As a result, stop using the private class BluetoothDeviceChromeOS from outside
of the //device/bluetooth component.

BUG=423114
TEST=compiles
R=armansito@chromium.org

Committed: https://crrev.com/764baa24e4eb6a215551831b9d4d30316c724323
Cr-Commit-Position: refs/heads/master@{#299841}

[armansito, 2014-10-15 19:02:16]

lgtm with one nit. Thanks for clean up!

https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
device/bluetooth/bluetooth_device.h:370: const ConnectToServiceErrorCallback&
error_callback) = 0;
Kind of tangential to this CL, though I wonder why ConnectToServiceErrorCallback
doesn't return (in an argument) an enum ConnectErrorCode. It's strange that we
have different signatures for Connect and ConnectToService*. Perhaps add a TODO
for this, if what I'm saying makes sense to you.

[Ilya Sherman, 2014-10-15 22:04:45]

https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
File device/bluetooth/bluetooth_device.h (right):

https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
device/bluetooth/bluetooth_device.h:370: const ConnectToServiceErrorCallback&
error_callback) = 0;
On 2014/10/15 19:02:16, armansito wrote:
> Kind of tangential to this CL, though I wonder why
ConnectToServiceErrorCallback
> doesn't return (in an argument) an enum ConnectErrorCode. It's strange that we
> have different signatures for Connect and ConnectToService*. Perhaps add a
TODO
> for this, if what I'm saying makes sense to you.

I personally find the strings more convenient than an enum, since most code that
handles connection failures doesn't really treat different failure reasons
differently, other than maybe logging the failure reason.  I'm therefore going
to omit the TODO, since I think it's worth discussing a bit more to figure out
what behavior we want, exactly.  In general, though, making Connect and
ConnectToService* have roughly the same signature makes sense to me.

[Ilya Sherman, 2014-10-15 22:04:49]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-10-15 22:05:08]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2014-10-15 22:05:50]

isherman@chromium.org changed reviewers:
+ tengs@chromium.org

[Ilya Sherman, 2014-10-15 22:05:50]

+Tim for change to
//chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
and //components/proximity_auth/*

[Tim Song, 2014-10-15 23:08:12]

lgtm

[armansito, 2014-10-15 23:13:16]

On 2014/10/15 22:04:45, Ilya Sherman wrote:
>
https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
> File device/bluetooth/bluetooth_device.h (right):
> 
>
https://codereview.chromium.org/652403002/diff/1/device/bluetooth/bluetooth_d...
> device/bluetooth/bluetooth_device.h:370: const ConnectToServiceErrorCallback&
> error_callback) = 0;
> On 2014/10/15 19:02:16, armansito wrote:
> > Kind of tangential to this CL, though I wonder why
> ConnectToServiceErrorCallback
> > doesn't return (in an argument) an enum ConnectErrorCode. It's strange that
we
> > have different signatures for Connect and ConnectToService*. Perhaps add a
> TODO
> > for this, if what I'm saying makes sense to you.
> 
> I personally find the strings more convenient than an enum, since most code
that
> handles connection failures doesn't really treat different failure reasons
> differently, other than maybe logging the failure reason.  I'm therefore going
> to omit the TODO, since I think it's worth discussing a bit more to figure out
> what behavior we want, exactly.  In general, though, making Connect and
> ConnectToService* have roughly the same signature makes sense to me.

sgtm

[Ilya Sherman, 2014-10-16 00:28:44]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:31:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652403002/1

[commit-bot: I haz the power, 2014-10-16 00:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:39:02]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/69191)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/73864)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Ilya Sherman, 2014-10-16 00:46:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:50:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652403002/20001

[commit-bot: I haz the power, 2014-10-16 03:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 03:24:09]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ilya Sherman, 2014-10-16 03:27:04]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-16 03:28:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652403002/20001

[commit-bot: I haz the power, 2014-10-16 04:45:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 04:46:25]

Patchset 2 (id:??) landed as
https://crrev.com/764baa24e4eb6a215551831b9d4d30316c724323
Cr-Commit-Position: refs/heads/master@{#299841}