ppapi/nacl_irt/plugin_main.cc - Issue 652393003: Non-SFI mode: Build ppapi libraries for nacl_helper_nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/nacl_irt/plugin_main.cc

Issue 652393003: Non-SFI mode: Build ppapi libraries for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/nacl_irt/plugin_main.cc

diff --git a/ppapi/nacl_irt/plugin_main.cc b/ppapi/nacl_irt/plugin_main.cc

index 8f0498c98eb2a9d1ea867690295864e952e99cb0..2b5e3b1a19689da95dd914d82915e9b57d832bb1 100644

--- a/ppapi/nacl_irt/plugin_main.cc

+++ b/ppapi/nacl_irt/plugin_main.cc

@@ -33,7 +33,7 @@ int PpapiPluginMain() {

base::MessageLoop loop;

ppapi::proxy::PluginGlobals plugin_globals;

-#if defined(__native_client__)

+#if defined(OS_NACL_SFI)

// Currently on non-SFI mode, we don't use SRPC server on plugin.

// TODO(hidehiko): Make sure this SRPC is actually used on SFI-mode.

teravest 2014/10/29 16:20:07 Do you want to remove this comment about SRPC?

Mark Seaborn 2014/10/29 16:37:31 Having *some* TODO here is appropriate, because we

hidehiko 2014/10/30 00:34:41 Yes, this is intentional. I'll look into this late

« no previous file with comments | « ppapi/nacl_irt/manifest_service.cc ('k') | ppapi/ppapi_ipc_nacl.gyp » ('j') | no next file with comments »