Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 652393002: cc: Make RenderPassAndMaskWithPartialQuad not use arbitrary uvs (Closed)

Created:
6 years, 2 months ago by enne (OOO)
Modified:
6 years, 2 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, reveman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Make RenderPassAndMaskWithPartialQuad not use arbitrary uvs This is the only test that uses the available functionality of RenderPassDrawQuad to specify an arbitrary uv rect. All other users in cc assume that the rect for the RenderPassDrawQuad also specifies the uvs (with the origin being the start of the mask), modulo some scale if the render pass is clipped. This test conversion is just a refactoring step to make removing the uv rect easier. R=danakj@chromium.org BUG=423533 Committed: https://crrev.com/35cfbe00f27c1284d0067ffc07b3fb1606dee155 Cr-Commit-Position: refs/heads/master@{#299622}

Patch Set 1 #

Total comments: 3

Patch Set 2 : danakj review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
A cc/test/data/mask_bottom_right.png View 1 Binary file 0 comments Download

Messages

Total messages: 7 (1 generated)
enne (OOO)
PTAL This test now locates the mask at the origin, instead of at 50, 50. ...
6 years, 2 months ago (2014-10-14 22:54:28 UTC) #1
danakj
LGTM https://codereview.chromium.org/652393002/diff/1/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/652393002/diff/1/cc/output/renderer_pixeltest.cc#newcode1260 cc/output/renderer_pixeltest.cc:1260: base::FilePath(FILE_PATH_LITERAL("mask_partial_quad.png")), can you name the image like "mask_bottom_right" ...
6 years, 2 months ago (2014-10-15 00:10:19 UTC) #2
enne (OOO)
https://codereview.chromium.org/652393002/diff/1/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/652393002/diff/1/cc/output/renderer_pixeltest.cc#newcode1260 cc/output/renderer_pixeltest.cc:1260: base::FilePath(FILE_PATH_LITERAL("mask_partial_quad.png")), On 2014/10/15 00:10:19, danakj wrote: > can you ...
6 years, 2 months ago (2014-10-15 01:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652393002/20001
6 years, 2 months ago (2014-10-15 01:09:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 01:46:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 01:50:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35cfbe00f27c1284d0067ffc07b3fb1606dee155
Cr-Commit-Position: refs/heads/master@{#299622}

Powered by Google App Engine
This is Rietveld 408576698