Issue 652363002: Glyph index is out of range in cff_get_glyph_name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652363002: Glyph index is out of range in cff_get_glyph_name. (Closed)

Created:
6 years, 2 months ago by jun_fang

Modified:
5 years, 9 months ago

Reviewers:
Tom Sepez, Bo Xu

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Glyph index is out of range in cff_get_glyph_name. Glyph index shall be less than number of glyphs. BUG=418585 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9776eca31c69dfa154e20b784a9df396b134758f

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	core/src/fxge/fx_freetype/fxft2.5.01/src/base/ftobjs.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

LGTM. FYI, I did a quick scan for other uses of <= num_glyphs, but only ...

6 years, 2 months ago (2014-10-14 20:47:51 UTC) #4

jun_fang

6 years, 2 months ago (2014-10-14 20:57:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9776eca31c69dfa154e20b784a9df396b134758f (presubmit successful).