Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652353003: Chromecast: adds class to help record complex histograms. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds class to help record complex histograms. R=lcwu@chromium.org,damienv@chromium.org BUG=336640 Committed: https://crrev.com/7d57bdc3c5afc1fd8a5c2ef72c751735582962a1 Cr-Commit-Position: refs/heads/master@{#300365}

Patch Set 1 #

Total comments: 2

Patch Set 2 : resets initial buffering state on flush #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -0 lines) Patch
M chromecast/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A chromecast/base/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A chromecast/base/metrics/cast_histograms.h View 1 chunk +49 lines, -0 lines 0 comments Download
A chromecast/base/metrics/cast_metrics_helper.h View 1 chunk +124 lines, -0 lines 0 comments Download
A chromecast/base/metrics/cast_metrics_helper.cc View 1 chunk +231 lines, -0 lines 0 comments Download
A chromecast/base/metrics/cast_metrics_test_helper.h View 1 chunk +19 lines, -0 lines 0 comments Download
A chromecast/base/metrics/cast_metrics_test_helper.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chromecast/browser/cast_browser_process.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/browser/cast_browser_process.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 3 chunks +24 lines, -0 lines 0 comments Download
M chromecast/media/cma/base/buffering_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cma/base/buffering_controller.cc View 1 4 chunks +12 lines, -0 lines 0 comments Download
M chromecast/media/cma/test/run_all_unittests.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chromecast/media/media.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
gunsch
6 years, 2 months ago (2014-10-14 22:24:54 UTC) #1
lcwu1
lgtm
6 years, 2 months ago (2014-10-15 23:30:32 UTC) #2
damienv1
https://codereview.chromium.org/652353003/diff/1/chromecast/media/cma/base/buffering_controller.cc File chromecast/media/cma/base/buffering_controller.cc (right): https://codereview.chromium.org/652353003/diff/1/chromecast/media/cma/base/buffering_controller.cc#newcode111 chromecast/media/cma/base/buffering_controller.cc:111: stream_list_.clear(); Should initial_buffering_ be reset here as well ?
6 years, 2 months ago (2014-10-16 00:00:13 UTC) #3
gunsch
https://codereview.chromium.org/652353003/diff/1/chromecast/media/cma/base/buffering_controller.cc File chromecast/media/cma/base/buffering_controller.cc (right): https://codereview.chromium.org/652353003/diff/1/chromecast/media/cma/base/buffering_controller.cc#newcode111 chromecast/media/cma/base/buffering_controller.cc:111: stream_list_.clear(); On 2014/10/16 00:00:13, damienv1 wrote: > Should initial_buffering_ ...
6 years, 2 months ago (2014-10-20 21:36:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652353003/20001
6 years, 2 months ago (2014-10-20 21:40:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 22:44:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:45:50 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7d57bdc3c5afc1fd8a5c2ef72c751735582962a1
Cr-Commit-Position: refs/heads/master@{#300365}

Powered by Google App Engine
This is Rietveld 408576698