Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 652343002: Telemetry: Pin Nexus 5 cores online. Limit CPU & GPU frequency. (Closed)

Created:
6 years, 2 months ago by vmiura
Modified:
5 years, 10 months ago
Reviewers:
pasko, dtu, Sami, tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, epenner, rmistry1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Pin Nexus 5 cores online. Limit CPU & GPU frequency. The Nexus 5 throttles CPU clock quickly under load, going from 2.27GHz down to 1.19GHz. Current Performance Dashboard results show this, as they tend to ping-pong between best & worst thermal states. This CL turns on all 4 cores on N5, and limits CPU to 1.19GHz which matches scaling under high load. It also limits GPU from 450MHz down to 200Mhz. BUG=383566 Committed: https://crrev.com/2239cb64943b945fee522d58518e955d237da193 Cr-Commit-Position: refs/heads/master@{#299770}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M build/android/pylib/perf/perf_control.py View 1 5 chunks +35 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
vmiura
ptal
6 years, 2 months ago (2014-10-14 19:48:00 UTC) #2
dtu
lgtm
6 years, 2 months ago (2014-10-14 23:05:23 UTC) #4
Sami
https://codereview.chromium.org/652343002/diff/1/build/android/pylib/perf/perf_control.py File build/android/pylib/perf/perf_control.py (right): https://codereview.chromium.org/652343002/diff/1/build/android/pylib/perf/perf_control.py#newcode82 build/android/pylib/perf/perf_control.py:82: }.get(product_model, 'ondemand') Is this the right choice for Nexus ...
6 years, 2 months ago (2014-10-15 13:29:17 UTC) #5
vmiura
https://codereview.chromium.org/652343002/diff/1/build/android/pylib/perf/perf_control.py File build/android/pylib/perf/perf_control.py (right): https://codereview.chromium.org/652343002/diff/1/build/android/pylib/perf/perf_control.py#newcode82 build/android/pylib/perf/perf_control.py:82: }.get(product_model, 'ondemand') On 2014/10/15 13:29:17, Sami wrote: > Is ...
6 years, 2 months ago (2014-10-15 20:15:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652343002/20001
6 years, 2 months ago (2014-10-15 20:16:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 21:26:01 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2239cb64943b945fee522d58518e955d237da193 Cr-Commit-Position: refs/heads/master@{#299770}
6 years, 2 months ago (2014-10-15 21:26:40 UTC) #10
epennerAtGoogle
+Tony for heads up. I was out sick. I think this is great but only ...
6 years, 2 months ago (2014-10-16 18:13:06 UTC) #12
rmistry
On 2014/10/16 18:13:06, epennerAtGoogle wrote: > +Tony for heads up. > > I was out ...
5 years, 10 months ago (2015-01-30 14:48:31 UTC) #13
vmiura
5 years, 10 months ago (2015-01-30 17:16:51 UTC) #14
Message was sent while issue was closed.
On 2015/01/30 14:48:31, rmistry wrote:
> On 2014/10/16 18:13:06, epennerAtGoogle wrote:
> > +Tony for heads up.
> > 
> > I was out sick. I think this is great but only concern is that this mode is
> set
> > for all of Telemetry. Might be good to give a fairly wide heads-up to test
> > owners.
> 
> I know this CL is a few months old but a question for my understanding:
> Does this change limit CPU and GPU on N5s for all telemetry benchmarks (i.e.
> repaint, rasterize_and_record_micro)?

Yes, I think all benchmarks currently use SetHighPerfMode().

Powered by Google App Engine
This is Rietveld 408576698