extensions/renderer/api/serial/serial_api_unittest.cc - Issue 652313002: Enable the mojo-based serial API in the renderer behind a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/serial/serial_api_unittest.cc

Issue 652313002: Enable the mojo-based serial API in the renderer behind a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-js-natives-registration

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/service_registration_manager.cc ('K') | « extensions/renderer/api/serial/data_sender_unittest.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | extensions/test/service_registration_manager_test_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/serial/serial_api_unittest.cc

diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc

index 9a07cd7af672109d8adcdf0dc4b5eb674b3e2322..1a4d9944b4be67fb8d8b68559545b054f5c9505c 100644

--- a/extensions/renderer/api/serial/serial_api_unittest.cc

+++ b/extensions/renderer/api/serial/serial_api_unittest.cc

@@ -396,18 +396,7 @@ class SerialApiTest : public ApiTestBase {

virtual void SetUp() override {

ApiTestBase::SetUp();

- env()->RegisterModule("async_waiter", IDR_ASYNC_WAITER_JS);

- env()->RegisterModule("data_receiver", IDR_DATA_RECEIVER_JS);

- env()->RegisterModule("data_sender", IDR_DATA_SENDER_JS);

env()->RegisterModule("serial", IDR_SERIAL_CUSTOM_BINDINGS_JS);

- env()->RegisterModule("serial_service", IDR_SERIAL_SERVICE_JS);

- env()->RegisterModule("device/serial/data_stream.mojom",

- IDR_DATA_STREAM_MOJOM_JS);

- env()->RegisterModule("device/serial/data_stream_serialization.mojom",

- IDR_DATA_STREAM_SERIALIZATION_MOJOM_JS);

- env()->RegisterModule("device/serial/serial.mojom", IDR_SERIAL_MOJOM_JS);

- env()->RegisterModule("device/serial/serial_serialization.mojom",

- IDR_SERIAL_SERIALIZATION_MOJOM_JS);

service_provider()->AddService<device::serial::SerialService>(base::Bind(

&SerialApiTest::CreateSerialService, base::Unretained(this)));

}