Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 652303002: Correct semantics for numerically indexed stores to typed arrays. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Patch Set 3 : stray empty line #

Patch Set 4 : Test for -0 #

Patch Set 5 : Also test for strict mode #

Patch Set 6 : Disabled test, filed bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
M src/lookup.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/lookup.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 2 3 4 5 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-14 15:49:10 UTC) #1
Toon Verwaest
https://codereview.chromium.org/652303002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/652303002/diff/1/src/objects.cc#newcode2986 src/objects.cc:2986: // disallow adding properties with numeric names. Please put ...
6 years, 2 months ago (2014-10-17 09:26:45 UTC) #2
Dmitry Lomov (no reviews)
Comments addressed https://codereview.chromium.org/652303002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/652303002/diff/1/src/objects.cc#newcode2986 src/objects.cc:2986: // disallow adding properties with numeric names. ...
6 years, 2 months ago (2014-10-17 09:50:33 UTC) #3
Toon Verwaest
lgtm
6 years, 2 months ago (2014-10-17 11:20:18 UTC) #4
Dmitry Lomov (no reviews)
Committed patchset #5 (id:80001) manually as 24691 (presubmit successful).
6 years, 2 months ago (2014-10-17 11:40:49 UTC) #5
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-17 16:33:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as 24705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698