Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 652293005: Adding a special build and test script for athena (Closed)

Created:
6 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 2 months ago
Reviewers:
dnj, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding a special build and test script for athena This will land shortly before 650403004 gets landed. BUG=410400 TEST=- Committed: https://crrev.com/01c9e93fb56b8fe1572ac13ecd6f997535fb0e4c Cr-Commit-Position: refs/heads/master@{#301122}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A testing/buildbot/chromium_athena.json View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 2 months ago (2014-10-23 23:24:37 UTC) #2
sky
https://codereview.chromium.org/652293005/diff/1/testing/buildbot/chromium_athena.json File testing/buildbot/chromium_athena.json (right): https://codereview.chromium.org/652293005/diff/1/testing/buildbot/chromium_athena.json#newcode7 testing/buildbot/chromium_athena.json:7: "browser_tests", You'll want to swarm this. https://codereview.chromium.org/652293005/diff/1/testing/buildbot/chromium_athena.json#newcode8 testing/buildbot/chromium_athena.json:8: "athena_unittests" ...
6 years, 2 months ago (2014-10-23 23:52:33 UTC) #4
Mr4D (OOO till 08-26)
Addressed. I thought about that myself, but since there is only a hand full of ...
6 years, 2 months ago (2014-10-24 14:11:38 UTC) #5
sky
LGTM - I assume browser_tests is chrome's browser_tests. You definitely want to shard them now.
6 years, 2 months ago (2014-10-24 15:12:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652293005/20001
6 years, 2 months ago (2014-10-24 15:23:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 16:33:34 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:34:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01c9e93fb56b8fe1572ac13ecd6f997535fb0e4c
Cr-Commit-Position: refs/heads/master@{#301122}

Powered by Google App Engine
This is Rietveld 408576698