content/browser/renderer_host/render_message_filter.cc - Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use struct as IPC params Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_message_filter.h ('k') | content/browser/transition_browsertest.cc » ('j') | content/browser/transition_request_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_message_filter.cc

diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc

index 546a95eba93c74e986d647debcd3595fd75ac6c2..4146c91d7ee607245e788c36a1cf77982e055a5c 100644

--- a/content/browser/renderer_host/render_message_filter.cc

+++ b/content/browser/renderer_host/render_message_filter.cc

@@ -1227,13 +1227,15 @@ void RenderMessageFilter::OnWebAudioMediaCodec(

#endif

void RenderMessageFilter::OnAddNavigationTransitionData(

- int render_frame_id,

- const std::string& allowed_destination_host_pattern,

- const std::string& selector,

- const std::string& markup) {

+ FrameHostMsg_AddNavigationTransitionData_Params params) {

TransitionRequestManager::GetInstance()->AddPendingTransitionRequestData(

- render_process_id_, render_frame_id, allowed_destination_host_pattern,

- selector, markup);

+ render_process_id_,

+ params.render_frame_id,

+ params.allowed_destination_host_pattern,

+ params.selector,

+ params.markup,

+ params.names,

+ params.rects);

}

void RenderMessageFilter::OnAllocateGpuMemoryBuffer(