Source/core/dom/shadow/InsertionPoint.cpp - Issue 652223002: Support style invalidation for ::content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/InsertionPoint.cpp

Issue 652223002: Support style invalidation for ::content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/shadow/InsertionPoint.cpp

diff --git a/Source/core/dom/shadow/InsertionPoint.cpp b/Source/core/dom/shadow/InsertionPoint.cpp

index 80a1bfa418f16b37ac8dd6da9d08b6a8cc29402c..8641059b6f7bb324a6ecfc72428fdbcbbf913094 100644

--- a/Source/core/dom/shadow/InsertionPoint.cpp

+++ b/Source/core/dom/shadow/InsertionPoint.cpp

@@ -120,7 +120,7 @@ void InsertionPoint::detach(const AttachContext& context)

void InsertionPoint::willRecalcStyle(StyleRecalcChange change)

{

- if (change < Inherit)

+ if (change < Inherit && styleChangeType() < SubtreeStyleChange)

chrishtr 2014/10/16 02:02:51 Is this part all that's needed to fix the attached

rune 2014/10/16 07:23:32 Yes. I started out to support invalidation for ::c

return;

for (size_t i = 0; i < m_distribution.size(); ++i)

m_distribution.at(i)->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::PropagateInheritChangeToDistributedNodes));

« Source/core/css/invalidation/StyleInvalidator.cpp ('K') | « Source/core/css/invalidation/StyleInvalidator.cpp ('k') | no next file » | no next file with comments »