Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 652193006: move functions in v8::V8 that should be on v8::Isolate (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne, marja
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

move functions in v8::V8 that should be on v8::Isolate R=marja@chromium.org, svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24921

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -217 lines) Patch
M include/v8.h View 1 2 17 chunks +297 lines, -47 lines 0 comments Download
M src/api.cc View 1 2 11 chunks +141 lines, -170 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dcarney
ptal
6 years, 1 month ago (2014-10-27 14:53:18 UTC) #2
marja
rubberstamp lgtm
6 years, 1 month ago (2014-10-28 08:39:53 UTC) #4
dcarney
6 years, 1 month ago (2014-10-28 08:43:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698