Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 652183003: [Mojo] Add HTML bindings (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
hansmuller
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mojo] Add HTML bindings The HTML bindings for Mojo are based on the JS bindings. We simply package up the JavaScript code for the JS bindings into HTML containers so they can be loaded with HTML imports. R=hansmuller@chromium.org Committed: https://crrev.com/e4089c4e9016df20e47828be5d5fbaeb1aebc7ba Cr-Commit-Position: refs/heads/master@{#299599}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix up paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -5 lines) Patch
M mojo/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/html/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A mojo/public/html/convert_amd_modules_to_html.py View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
M mojo/public/js/bindings/codec.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.html.tmpl View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
abarth-chromium
6 years, 2 months ago (2014-10-14 19:21:34 UTC) #1
hansmuller
On 2014/10/14 19:21:34, abarth wrote: I not a Python authority but the code LGTM. Eventually ...
6 years, 2 months ago (2014-10-14 20:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652183003/40001
6 years, 2 months ago (2014-10-14 21:14:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/23998)
6 years, 2 months ago (2014-10-14 22:04:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652183003/40001
6 years, 2 months ago (2014-10-15 00:09:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-15 00:35:46 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 00:37:01 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4089c4e9016df20e47828be5d5fbaeb1aebc7ba
Cr-Commit-Position: refs/heads/master@{#299599}

Powered by Google App Engine
This is Rietveld 408576698