Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 652183002: Always initialize key_type_ in AST nodes (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Always initialize key_type_ in AST nodes BUG=chromium:423117 LOG=n R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/ast.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
mvstanton
Good idea. LGTM.
6 years, 2 months ago (2014-10-14 12:31:54 UTC) #2
Jakob Kummerow
6 years, 2 months ago (2014-10-14 13:52:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24604 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698