Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 652123002: sandbox_bpf: Remove Traverse method. (Closed)

Created:
6 years, 2 months ago by rickyz (no longer on Chrome)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

sandbox_bpf: Remove Traverse method. All calls to this were removed in https://codereview.chromium.org/628823003/. BUG=414363 Committed: https://crrev.com/d7e09730fb84eaf611a5a0edac79e9ca66033c5c Cr-Commit-Position: refs/heads/master@{#299436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M sandbox/linux/seccomp-bpf/codegen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.cc View 2 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rickyz (no longer on Chrome)
Looks like Traverse is no longer used - let me know if you think a ...
6 years, 2 months ago (2014-10-14 04:53:56 UTC) #2
mdempsky
LGTM Thanks, I had been meaning to remove that function. :-)
6 years, 2 months ago (2014-10-14 05:10:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652123002/1
6 years, 2 months ago (2014-10-14 05:24:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 05:58:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 06:17:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7e09730fb84eaf611a5a0edac79e9ca66033c5c
Cr-Commit-Position: refs/heads/master@{#299436}

Powered by Google App Engine
This is Rietveld 408576698