Source/modules/webaudio/PannerNode.cpp - Issue 652073003: Change the default panning mode from HRTF to equal-power

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/PannerNode.cpp

Issue 652073003: Change the default panning mode from HRTF to equal-power (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/resources/panner-model-testing.js ('K') | « LayoutTests/webaudio/resources/panner-model-testing.js ('k') | Source/modules/webaudio/PannerNode.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/PannerNode.cpp

diff --git a/Source/modules/webaudio/PannerNode.cpp b/Source/modules/webaudio/PannerNode.cpp

index bb2f85bcade245d84a983228dafad6c6d4f9ef87..dce477e4bc33d17f9a668e1a87f603398986e091 100644

--- a/Source/modules/webaudio/PannerNode.cpp

+++ b/Source/modules/webaudio/PannerNode.cpp

@@ -48,7 +48,7 @@ static void fixNANs(double &x)

PannerNode::PannerNode(AudioContext* context, float sampleRate)

: AudioNode(context, sampleRate)

- , m_panningModel(Panner::PanningModelHRTF)

+ , m_panningModel(Panner::PanningModelEqualPower)

, m_distanceModel(DistanceEffect::ModelInverse)

, m_position(0, 0, 0)

, m_orientation(1, 0, 0)

@@ -198,7 +198,7 @@ String PannerNode::panningModel() const

return "HRTF";

default:

ASSERT_NOT_REACHED();

- return "HRTF";

+ return "equalpower";

}