Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/webaudio/pannernode-basic.html

Issue 652073003: Change the default panning mode from HRTF to equal-power (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« LayoutTests/webaudio/panner-loop.html ('K') | « LayoutTests/webaudio/panner-loop.html ('k') | LayoutTests/webaudio/pannernode-basic-expected.txt » ('j') | LayoutTests/webaudio/resources/panner-model-testing.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="../resources/js-test.js"></script> 4 <script src="../resources/js-test.js"></script>
5 <script src="resources/compatibility.js"></script> 5 <script src="resources/compatibility.js"></script>
6 <script src="resources/audio-testing.js"></script> 6 <script src="resources/audio-testing.js"></script>
7 </head> 7 </head>
8 8
9 <body> 9 <body>
10 <div id="description"></div> 10 <div id="description"></div>
11 <div id="console"></div> 11 <div id="console"></div>
12 12
13 <script> 13 <script>
14 description("Basic tests for PannerNode."); 14 description("Basic tests for PannerNode.");
15 15
16 var context = 0; 16 var context = 0;
17 17
18 function runTest() { 18 function runTest() {
19 if (window.testRunner) { 19 if (window.testRunner) {
20 testRunner.dumpAsText(); 20 testRunner.dumpAsText();
21 testRunner.waitUntilDone(); 21 testRunner.waitUntilDone();
22 } 22 }
23 23
24 window.jsTestIsAsync = true; 24 window.jsTestIsAsync = true;
25 25
26 context = new AudioContext(); 26 context = new AudioContext();
27 var panner = context.createPanner(); 27 var panner = context.createPanner();
28 28
29 if (panner.numberOfInputs === 1) 29 if (panner.numberOfInputs === 1)
Raymond Toy 2014/10/17 17:39:30 I don't see what's different here? Did you delete
hongchan 2014/10/17 18:13:40 Yes, I deleted trailing spaces and indents on empt
30 testPassed("PannerNode has one input."); 30 testPassed("PannerNode has one input.");
31 else 31 else
32 testFailed("PannerNode should have one input."); 32 testFailed("PannerNode should have one input.");
33 33
34 if (panner.numberOfOutputs === 1) 34 if (panner.numberOfOutputs === 1)
35 testPassed("PannerNode has one output."); 35 testPassed("PannerNode has one output.");
36 else 36 else
37 testFailed("PannerNode should have one output."); 37 testFailed("PannerNode should have one output.");
38 38
39 if (panner.refDistance === 1) 39 if (panner.refDistance === 1)
40 testPassed("refDistance default value is 1."); 40 testPassed("refDistance default value is 1.");
41 else 41 else
42 testFailed("refDistance default value should be 1."); 42 testFailed("refDistance default value should be 1.");
43 43
44 panner.refDistance = 270.52 44 panner.refDistance = 270.52
45 if (panner.refDistance === 270.52) 45 if (panner.refDistance === 270.52)
46 testPassed("refDistance value is set to 270.52."); 46 testPassed("refDistance value is set to 270.52.");
47 else 47 else
48 testFailed("refDistance value should be set to 270.52."); 48 testFailed("refDistance value should be set to 270.52.");
49 49
Raymond Toy 2014/10/17 17:39:30 Did you remove a blank line here? (And same commen
hongchan 2014/10/17 18:13:40 Yes.
50 if (panner.maxDistance === 10000) 50 if (panner.maxDistance === 10000)
51 testPassed("maxDistance default value is 10000."); 51 testPassed("maxDistance default value is 10000.");
52 else 52 else
53 testFailed("maxDistance default value should be 10000."); 53 testFailed("maxDistance default value should be 10000.");
54 54
55 panner.maxDistance = 100.55 55 panner.maxDistance = 100.55
56 if (panner.maxDistance === 100.55) 56 if (panner.maxDistance === 100.55)
57 testPassed("maxDistance value is set to 100.55."); 57 testPassed("maxDistance value is set to 100.55.");
58 else 58 else
59 testFailed("maxDistance value should be set to 100.55."); 59 testFailed("maxDistance value should be set to 100.55.");
60 60
61 if (panner.rolloffFactor === 1) 61 if (panner.rolloffFactor === 1)
62 testPassed("rolloffFactor default value is 1."); 62 testPassed("rolloffFactor default value is 1.");
63 else 63 else
64 testFailed("rolloffFactor default value should be 1."); 64 testFailed("rolloffFactor default value should be 1.");
65 65
66 panner.rolloffFactor = 0.83 66 panner.rolloffFactor = 0.83
67 if (panner.rolloffFactor === 0.83) 67 if (panner.rolloffFactor === 0.83)
68 testPassed("rolloffFactor value is set to 0.83."); 68 testPassed("rolloffFactor value is set to 0.83.");
69 else 69 else
70 testFailed("rolloffFactor value should be set to 0.83."); 70 testFailed("rolloffFactor value should be set to 0.83.");
71 71
72 if (panner.coneInnerAngle === 360) 72 if (panner.coneInnerAngle === 360)
73 testPassed("coneInnerAngle default value is 360."); 73 testPassed("coneInnerAngle default value is 360.");
74 else 74 else
75 testFailed("coneInnerAngle default value should be 360."); 75 testFailed("coneInnerAngle default value should be 360.");
76 76
77 panner.coneInnerAngle = 240.45 77 panner.coneInnerAngle = 240.45
78 if (panner.coneInnerAngle === 240.45) 78 if (panner.coneInnerAngle === 240.45)
79 testPassed("coneInnerAngle value is set to 240.45."); 79 testPassed("coneInnerAngle value is set to 240.45.");
80 else 80 else
81 testFailed("coneInnerAngle value should be set to 240.45."); 81 testFailed("coneInnerAngle value should be set to 240.45.");
82 82
83 if (panner.coneOuterAngle === 360) 83 if (panner.coneOuterAngle === 360)
84 testPassed("coneOuterAngle default value is 360."); 84 testPassed("coneOuterAngle default value is 360.");
85 else 85 else
86 testFailed("coneOuterAngle default value should be 360."); 86 testFailed("coneOuterAngle default value should be 360.");
87 87
88 panner.coneOuterAngle = 166.66 88 panner.coneOuterAngle = 166.66
89 if (panner.coneOuterAngle === 166.66) 89 if (panner.coneOuterAngle === 166.66)
90 testPassed("coneOuterAngle value is set to 166.66."); 90 testPassed("coneOuterAngle value is set to 166.66.");
91 else 91 else
92 testFailed("coneOuterAngle value should be set to 166.66."); 92 testFailed("coneOuterAngle value should be set to 166.66.");
93 93
94 if (panner.coneOuterGain === 0) 94 if (panner.coneOuterGain === 0)
95 testPassed("coneOuterGain default value is 0."); 95 testPassed("coneOuterGain default value is 0.");
96 else 96 else
97 testFailed("coneOuterGain default value should be 0."); 97 testFailed("coneOuterGain default value should be 0.");
98 98
99 panner.coneOuterGain = 0.35 99 panner.coneOuterGain = 0.35
100 if (panner.coneOuterGain === 0.35) 100 if (panner.coneOuterGain === 0.35)
101 testPassed("coneOuterGain value is set to 0.35."); 101 testPassed("coneOuterGain value is set to 0.35.");
102 else 102 else
103 testFailed("coneOuterGain value should be set to 0.35."); 103 testFailed("coneOuterGain value should be set to 0.35.");
104 104
105 if (panner.panningModel === "HRTF") 105 if (panner.panningModel === "equalpower")
106 testPassed("PannerNode defaults to 'HRTF' panningModel."); 106 testPassed("PannerNode defaults to 'equalpower' panningModel.");
107 else 107 else
108 testFailed("PannerNode should default to 'HRTF' panningModel."); 108 testFailed("PannerNode should default to 'equalpower' panningModel.");
109 109
110 if (panner.distanceModel === "inverse") 110 if (panner.distanceModel === "inverse")
111 testPassed("PannerNode defaults to 'inverse' distanceModel."); 111 testPassed("PannerNode defaults to 'inverse' distanceModel.");
112 else 112 else
113 testFailed("PannerNode should default to 'inverse' distanceModel."); 113 testFailed("PannerNode should default to 'inverse' distanceModel.");
114 114
115 // Check that the .panningModel attribute can be set to all legal values. 115 // Check that the .panningModel attribute can be set to all legal values.
116 var panningModels = [{value: "equalpower", integerValue: panner.EQUALPOWER}, 116 var panningModels = [{value: "equalpower", integerValue: panner.EQUALPOWER},
117 {value: "HRTF", integerValue: panner.HRTF}, 117 {value: "HRTF", integerValue: panner.HRTF},
118 ]; 118 ];
119 119
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 175
176 finishJSTest(); 176 finishJSTest();
177 } 177 }
178 178
179 runTest(); 179 runTest();
180 180
181 </script> 181 </script>
182 182
183 </body> 183 </body>
184 </html> 184 </html>
OLDNEW
« LayoutTests/webaudio/panner-loop.html ('K') | « LayoutTests/webaudio/panner-loop.html ('k') | LayoutTests/webaudio/pannernode-basic-expected.txt » ('j') | LayoutTests/webaudio/resources/panner-model-testing.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698