Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 652073002: chromeos: Don't apply stale display power state after resume (Closed)

Created:
6 years, 2 months ago by Daniel Erat
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, dnicoara
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chromeos: Don't apply stale display power state after resume Fix an issue where the last-requested display power state was bound to a delayed task on resume. If a new state was requested while the task was waiting to run (e.g. due to exiting docked mode), the task would later restore the old state. Instead, add a thunk for the task that always uses the currently-requested state. BUG=chrome-os-partner:32393 Committed: https://crrev.com/c8052f9d1d76ecf5c616558b59913e4f4e59adc6 Cr-Commit-Position: refs/heads/master@{#299812}

Patch Set 1 #

Patch Set 2 : add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -10 lines) Patch
M ui/display/chromeos/display_configurator.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
(this still needs a test, but i'll wait until i hear that it fixes the ...
6 years, 2 months ago (2014-10-13 23:49:14 UTC) #1
Daniel Erat
oshima, do you mind reviewing this since dnicoara is out?
6 years, 2 months ago (2014-10-15 21:56:54 UTC) #3
oshima
lgtm
6 years, 2 months ago (2014-10-15 23:11:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652073002/20001
6 years, 2 months ago (2014-10-15 23:13:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 01:47:11 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:48:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8052f9d1d76ecf5c616558b59913e4f4e59adc6
Cr-Commit-Position: refs/heads/master@{#299812}

Powered by Google App Engine
This is Rietveld 408576698