Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 652033004: Android: Remove some devtools code from the build. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: Remove some devtools code from the build. BUG=159847 Committed: https://crrev.com/42abef62e59d966e30f076eff4cd192c75e2d731 Cr-Commit-Position: refs/heads/master@{#301579}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 chunks +6 lines, -1 line 1 comment Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
6 years, 1 month ago (2014-10-28 02:42:45 UTC) #2
dgozman
devtools_targets_ui.* and devtools_ui_bindings.* are not compiled on Android (see chrome_debugger.gypi and chrome/browser/devtools/BUILD.gn), so changing them ...
6 years, 1 month ago (2014-10-28 05:27:07 UTC) #3
Lei Zhang
PTAL at patch set 3. https://codereview.chromium.org/652033004/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://codereview.chromium.org/652033004/diff/1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode463 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:463: // (Shared Workers, extensions, ...
6 years, 1 month ago (2014-10-28 05:52:43 UTC) #4
dgozman
lgtm
6 years, 1 month ago (2014-10-28 06:03:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652033004/40001
6 years, 1 month ago (2014-10-28 06:06:04 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-28 06:51:14 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:52:04 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/42abef62e59d966e30f076eff4cd192c75e2d731
Cr-Commit-Position: refs/heads/master@{#301579}

Powered by Google App Engine
This is Rietveld 408576698