Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 652013002: Update extension preference API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make extension preference backward compatible. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/extensions/extension_apitest.h" 9 #include "chrome/browser/extensions/extension_apitest.h"
10 #include "chrome/browser/net/prediction_options.h"
10 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
12 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
13 #include "chrome/common/pref_names.h" 14 #include "chrome/common/pref_names.h"
14 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
15 #include "components/translate/core/common/translate_pref_names.h" 16 #include "components/translate/core/common/translate_pref_names.h"
16 #include "content/public/browser/notification_service.h" 17 #include "content/public/browser/notification_service.h"
17 #include "extensions/browser/extension_registry.h" 18 #include "extensions/browser/extension_registry.h"
18 #include "extensions/browser/test_extension_registry_observer.h" 19 #include "extensions/browser/test_extension_registry_observer.h"
19 #include "extensions/test/extension_test_message_listener.h" 20 #include "extensions/test/extension_test_message_listener.h"
(...skipping 16 matching lines...) Expand all
36 const PrefService::Preference* pref = prefs->FindPreference( 37 const PrefService::Preference* pref = prefs->FindPreference(
37 prefs::kBlockThirdPartyCookies); 38 prefs::kBlockThirdPartyCookies);
38 ASSERT_TRUE(pref); 39 ASSERT_TRUE(pref);
39 EXPECT_TRUE(pref->IsExtensionControlled()); 40 EXPECT_TRUE(pref->IsExtensionControlled());
40 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 41 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
41 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 42 EXPECT_TRUE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
42 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 43 EXPECT_FALSE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
43 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 44 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
44 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers)); 45 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableReferrers));
45 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate)); 46 EXPECT_TRUE(prefs->GetBoolean(prefs::kEnableTranslate));
46 EXPECT_TRUE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled)); 47 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT,
48 prefs->GetInteger(prefs::kNetworkPredictionOptions));
47 EXPECT_TRUE(prefs->GetBoolean( 49 EXPECT_TRUE(prefs->GetBoolean(
48 password_manager::prefs::kPasswordManagerSavingEnabled)); 50 password_manager::prefs::kPasswordManagerSavingEnabled));
49 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 51 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
50 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 52 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
51 } 53 }
52 54
53 void CheckPreferencesCleared() { 55 void CheckPreferencesCleared() {
54 PrefService* prefs = profile_->GetPrefs(); 56 PrefService* prefs = profile_->GetPrefs();
55 const PrefService::Preference* pref = prefs->FindPreference( 57 const PrefService::Preference* pref = prefs->FindPreference(
56 prefs::kBlockThirdPartyCookies); 58 prefs::kBlockThirdPartyCookies);
57 ASSERT_TRUE(pref); 59 ASSERT_TRUE(pref);
58 EXPECT_FALSE(pref->IsExtensionControlled()); 60 EXPECT_FALSE(pref->IsExtensionControlled());
59 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 61 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
60 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled)); 62 EXPECT_FALSE(prefs->GetBoolean(autofill::prefs::kAutofillEnabled));
61 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies)); 63 EXPECT_TRUE(prefs->GetBoolean(prefs::kBlockThirdPartyCookies));
62 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing)); 64 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableHyperlinkAuditing));
63 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers)); 65 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableReferrers));
64 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate)); 66 EXPECT_FALSE(prefs->GetBoolean(prefs::kEnableTranslate));
65 EXPECT_FALSE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled)); 67 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER,
68 prefs->GetInteger(prefs::kNetworkPredictionOptions));
66 EXPECT_FALSE(prefs->GetBoolean( 69 EXPECT_FALSE(prefs->GetBoolean(
67 password_manager::prefs::kPasswordManagerSavingEnabled)); 70 password_manager::prefs::kPasswordManagerSavingEnabled));
68 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 71 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
69 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 72 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
70 } 73 }
71 74
72 virtual void SetUpOnMainThread() override { 75 virtual void SetUpOnMainThread() override {
73 ExtensionApiTest::SetUpOnMainThread(); 76 ExtensionApiTest::SetUpOnMainThread();
74 77
75 // The browser might get closed later (and therefore be destroyed), so we 78 // The browser might get closed later (and therefore be destroyed), so we
(...skipping 26 matching lines...) Expand all
102 #define MAYBE_Standard Standard 105 #define MAYBE_Standard Standard
103 #endif 106 #endif
104 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) { 107 IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, MAYBE_Standard) {
105 PrefService* prefs = profile_->GetPrefs(); 108 PrefService* prefs = profile_->GetPrefs();
106 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false); 109 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false);
107 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false); 110 prefs->SetBoolean(autofill::prefs::kAutofillEnabled, false);
108 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true); 111 prefs->SetBoolean(prefs::kBlockThirdPartyCookies, true);
109 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false); 112 prefs->SetBoolean(prefs::kEnableHyperlinkAuditing, false);
110 prefs->SetBoolean(prefs::kEnableReferrers, false); 113 prefs->SetBoolean(prefs::kEnableReferrers, false);
111 prefs->SetBoolean(prefs::kEnableTranslate, false); 114 prefs->SetBoolean(prefs::kEnableTranslate, false);
112 prefs->SetBoolean(prefs::kNetworkPredictionEnabled, false); 115 prefs->SetInteger(prefs::kNetworkPredictionOptions,
116 chrome_browser_net::NETWORK_PREDICTION_NEVER);
113 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled, 117 prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,
114 false); 118 false);
115 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); 119 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);
116 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); 120 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);
117 121
118 const char kExtensionPath[] = "preference/standard"; 122 const char kExtensionPath[] = "preference/standard";
119 123
120 EXPECT_TRUE(RunExtensionSubtest(kExtensionPath, "test.html")) << message_; 124 EXPECT_TRUE(RunExtensionSubtest(kExtensionPath, "test.html")) << message_;
121 CheckPreferencesSet(); 125 CheckPreferencesSet();
122 126
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 323
320 // Test 6 - clearDefault 324 // Test 6 - clearDefault
321 EXPECT_TRUE(listener10.WaitUntilSatisfied()); // Regular ready 325 EXPECT_TRUE(listener10.WaitUntilSatisfied()); // Regular ready
322 EXPECT_TRUE(listener_incognito10.WaitUntilSatisfied()); // Incognito ready 326 EXPECT_TRUE(listener_incognito10.WaitUntilSatisfied()); // Incognito ready
323 listener10.Reply("ok"); 327 listener10.Reply("ok");
324 listener_incognito10.Reply("ok"); 328 listener_incognito10.Reply("ok");
325 329
326 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 330 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
327 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message(); 331 EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message();
328 } 332 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698