Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 652003002: Add ThreadSnapshotMac (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -0 lines) Patch
M snapshot/snapshot.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A snapshot/thread_snapshot_mac.h View 1 chunk +85 lines, -0 lines 0 comments Download
A snapshot/thread_snapshot_mac.cc View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This doesn’t have its own test because of bug 2. This just wraps existing well-tested ...
6 years, 2 months ago (2014-10-13 19:09:49 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-13 20:53:58 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-13 22:06:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
356a2db147d332c6f8af77ab301398f3931448e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698