Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

Issue 651953006: improve method invocation and string interpolation suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
index 4c7e439b811665153cc293db845a0a3fe499f2f2..798e69d999a3d437ca6e11863071a0b3367449e4 100644
--- a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
@@ -50,6 +50,15 @@ class _InvocationAstVisitor extends GeneralizingAstVisitor<Future<bool>> {
}
@override
+ Future<bool> visitMethodInvocation(MethodInvocation node) {
+ Token period = node.period;
+ if (period == null || period.offset < request.offset) {
+ _addExpressionSuggestions(node.target);
+ }
+ return new Future.value(false);
+ }
+
+ @override
Future<bool> visitNode(AstNode node) {
return new Future.value(false);
}
@@ -67,7 +76,8 @@ class _InvocationAstVisitor extends GeneralizingAstVisitor<Future<bool>> {
@override
Future<bool> visitPropertyAccess(PropertyAccess node) {
- if (request.offset > node.offset) {
+ Token operator = node.operator;
+ if (operator != null && operator.offset < request.offset) {
return _addExpressionSuggestions(node.realTarget);
}
return super.visitPropertyAccess(node);

Powered by Google App Engine
This is Rietveld 408576698