Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: content/app/content_main_runner.cc

Issue 65193003: Clear SingleProcess and InProcessGPU logic. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Add CommandLine::RemoveSwitch() to prevent --single-process when CHROME_MULTIPLE_DLL_BROWSER Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/command_line_unittest.cc ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/app/content_main_runner.cc
diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc
index da27afaaf017aa36d9ca79c77b98cbf032ac72f3..29f4f5d1345b54aafe3784d2a2ae3616d3656fba 100644
--- a/content/app/content_main_runner.cc
+++ b/content/app/content_main_runner.cc
@@ -437,6 +437,18 @@ int RunNamedProcessTypeMain(
CreateInProcessRendererThread);
GpuProcessHost::RegisterGpuMainThreadFactory(
CreateInProcessGpuThread);
+#else
+ CommandLine& command_line = *CommandLine::ForCurrentProcess();
+ if (command_line.HasSwitch(switches::kSingleProcess)) {
+ command_line.RemoveSwitch(switches::kSingleProcess);
+ LOG(ERROR) <<
+ "--single-process is not supported in chrome multiple dll browser.";
+ }
+ if (command_line.HasSwitch(switches::kInProcessGPU)) {
+ command_line.RemoveSwitch(switches::kInProcessGPU);
+ LOG(ERROR) <<
+ "--in-process-gpu is not supported in chrome multiple dll browser.";
+ }
dshwang 2013/11/18 16:47:26 I think here is suitable place to warn, because th
#endif
for (size_t i = 0; i < arraysize(kMainFunctions); ++i) {
« no previous file with comments | « base/command_line_unittest.cc ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698