Clear SingleProcess and InProcessGPU logic.

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
@@ skipping 419 matching lines @@
 #endif  // !CHROME_MULTIPLE_DLL_BROWSER
   };
 
 #if !defined(CHROME_MULTIPLE_DLL_BROWSER)
   UtilityProcessHost::RegisterUtilityMainThreadFactory(
       CreateInProcessUtilityThread);
   RenderProcessHost::RegisterRendererMainThreadFactory(
       CreateInProcessRendererThread);
   GpuProcessHost::RegisterGpuMainThreadFactory(
       CreateInProcessGpuThread);
+#else
+  // SingleProcess and InProcessGPU mode are not supported
+  // in multiple-dll mode currently.
+  CHECK(!(command_line.HasSwitch(switches::kSingleProcess) ||
+      command_line.HasSwitch(switches::kInProcessGPU)));

[piman, 2013/11/07 22:09:52]

I suspect some people currently use that. What's broken exactly?

[dshwang, 2013/11/08 10:05:56]

under defined(CHROME_MULTIPLE_DLL_BROWSER), we don't register InProcessGPU
thread constructor, CreateInProcessGpuThread, so we must not use
--in-process-gpu.

We launch GPU process if InProcessGPU thread constructor is not set although
--in-process-gpu.
if (in_process_ && g_gpu_main_thread_factory) {
  in_process_gpu_thread_->Start();
} else if (!LaunchGpuProcess(channel_id)) {
  return false;
}

However, we don't check g_gpu_main_thread_factory in other InProcessGPU code.
e.g. gpu process termination code
It can cause a bad bug.

Utility and Render process has the same issue to gpu process.

 #endif
 
   for (size_t i = 0; i < arraysize(kMainFunctions); ++i) {
     if (process_type == kMainFunctions[i].name) {
       if (delegate) {
         int exit_code = delegate->RunProcess(process_type,
             main_function_params);
 #if defined(OS_ANDROID)
         // In Android's browser process, the negative exit code doesn't mean the
         // default behavior should be used as the UI message loop is managed by
@@ skipping 385 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content