Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: build/android/pylib/gtest/test_runner.py

Issue 651923002: [Android] Push gtest deps in gtest/setup.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/test_package_apk.py ('k') | build/android/pylib/instrumentation/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_runner.py
diff --git a/build/android/pylib/gtest/test_runner.py b/build/android/pylib/gtest/test_runner.py
index b912d53ee7dfd4687ef862ff3b9de28967ef828e..9f89beb761b6a3c52fb1643833d9447304f1a81e 100644
--- a/build/android/pylib/gtest/test_runner.py
+++ b/build/android/pylib/gtest/test_runner.py
@@ -6,7 +6,6 @@ import logging
import os
import re
-from pylib import constants
from pylib import pexpect
from pylib.base import base_test_result
from pylib.base import base_test_runner
@@ -59,22 +58,6 @@ class TestRunner(base_test_runner.BaseTestRunner):
def InstallTestPackage(self):
self.test_package.Install(self.device)
- #override
- def PushDataDeps(self):
- self.device.WaitUntilFullyBooted(timeout=20)
- self.tool.CopyFiles()
- if os.path.exists(constants.ISOLATE_DEPS_DIR):
- # TODO(frankf): linux_dumper_unittest_helper needs to be in the same dir
- # as breakpad_unittests exe. Find a better way to do this.
- if self.test_package.suite_name == 'breakpad_unittests':
- device_dir = constants.TEST_EXECUTABLE_DIR
- else:
- device_dir = self.device.GetExternalStoragePath()
- self.device.PushChangedFiles(
- [(os.path.join(constants.ISOLATE_DEPS_DIR, p),
- os.path.join(device_dir, p))
- for p in os.listdir(constants.ISOLATE_DEPS_DIR)])
-
def _ParseTestOutput(self, p):
"""Process the test output.
« no previous file with comments | « build/android/pylib/gtest/test_package_apk.py ('k') | build/android/pylib/instrumentation/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698