Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 651913003: base: Remove non-caching discardable memory implementation. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

base: Remove non-caching discardable memory implementation. This removes the "malloc" implementation of discardable memory. This implementation exists for test and debugging purproses but we currently don't have any tests that depend on it so it can be removed to reduce code size. This implementation can still be very useful to manually track down bugs and performance issues in discardable memory clients but can be maintained separately to reduce code size. BUG=422953 TBR=danakj@chromium.org Committed: https://crrev.com/e5f918c09ca74cc64f92ad5fd81f071687165248 Cr-Commit-Position: refs/heads/master@{#299374}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -130 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/memory/discardable_memory.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/memory/discardable_memory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/memory/discardable_memory_android.cc View 1 3 chunks +1 line, -11 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 3 chunks +1 line, -11 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 1 3 chunks +1 line, -11 lines 0 comments Download
D base/memory/discardable_memory_malloc.h View 1 chunk +0 lines, -35 lines 0 comments Download
D base/memory/discardable_memory_malloc.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
6 years, 2 months ago (2014-10-13 16:53:16 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-13 17:09:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651913003/150001
6 years, 2 months ago (2014-10-13 20:39:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:150001)
6 years, 2 months ago (2014-10-13 22:00:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:01:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5f918c09ca74cc64f92ad5fd81f071687165248
Cr-Commit-Position: refs/heads/master@{#299374}

Powered by Google App Engine
This is Rietveld 408576698